Remove __SHORT_FILE__ macro definition in CMake #11147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This per-file macro definition on the command line breaks caching of modules. See discussion in llvm#150677 Instead we use a constexpr variable to force the constexpr evaluation by the frontend, and also the __FILE_NAME__ macro when available (clang/gcc) to spare compile-time in the frontend. (cherry picked from commit 3918596)
jroelofs
deleted the
jroelofs/pick-39185965ac6884ffeff4fda20eb8fd0e0aa656d7-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This per-file macro definition on the command line breaks caching of modules. See discussion in llvm#150677
Instead we use a constexpr variable to force the constexpr evaluation by the frontend, and also the FILE_NAME macro when available (clang/gcc) to spare compile-time in the frontend.
(cherry picked from commit 3918596)